amaliujia commented on a change in pull request #1587: [CALCITE-3272] Support TUMBLE as Table Valued Function including an enumerable implementation, stream.iq and DESCRIPTOR URL: https://github.com/apache/calcite/pull/1587#discussion_r358056095
########## File path: core/src/main/java/org/apache/calcite/sql/SqlTableValuedFunctionWindowingOperator.java ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.sql; + +import org.apache.calcite.sql.type.SqlOperandTypeChecker; +import org.apache.calcite.sql.type.SqlOperandTypeInference; +import org.apache.calcite.sql.type.SqlReturnTypeInference; + +/** + * Base class for table-valued function windowing operator (TUMBLE, HOP and SESSION). + */ +public class SqlTableValuedFunctionWindowingOperator extends SqlFunction { + public SqlTableValuedFunctionWindowingOperator(String name, Review comment: Gotcha. Currently this PR is only supports `TUMBLE`, so we can make `TUMBLE to extends SqlFunction` and override `argumentMustBeScalar`. The plan is I will also add support for HOP(sliding windowing) and SESSION (sessionization), and those will also need to override `argumentMustBeScalar`, thus a base class will make sense for that time (and I just implement it in this PR). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
