chunweilei commented on a change in pull request #1655: [CALCITE-3387] Query
with GROUP BY and JOIN ... USING wrongly fails with "Column DEPTNO is
ambiguous" error
URL: https://github.com/apache/calcite/pull/1655#discussion_r358751213
##########
File path:
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java
##########
@@ -5943,6 +5999,30 @@ protected SqlNode visitScoped(SqlCall call) {
}
}
+ /**
+ * Converts an expression into canonical form by fully-qualifying any
+ * identifiers. For common columns in USING, it will be converted to
+ * COALESCE(A.col, B.col) AS col.
+ */
+ static class SelectExpander extends Expander {
+ final SqlSelect select;
+
+ SelectExpander(SqlValidatorImpl validator, SelectScope scope,
+ SqlSelect select) {
Review comment:
Will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
