chunweilei commented on a change in pull request #1655: [CALCITE-3387] Query
with GROUP BY and JOIN ... USING wrongly fails with "Column DEPTNO is
ambiguous" error
URL: https://github.com/apache/calcite/pull/1655#discussion_r358751603
##########
File path:
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java
##########
@@ -484,6 +484,52 @@ private boolean expandSelectItem(
return false;
}
+ private static SqlNode expandCommonColumn(SqlSelect sqlSelect,
+ SqlNode selectItem, SelectScope scope) {
+ if (!(selectItem instanceof SqlIdentifier)) {
+ return selectItem;
+ }
+
+ final SqlIdentifier identifier = (SqlIdentifier) selectItem;
+ if (!identifier.isSimple()) {
+ return selectItem;
+ }
+
+ final SqlNode from = sqlSelect.getFrom();
+ if (from == null || !(from instanceof SqlJoin)) {
+ return selectItem;
+ }
+
+ final SqlJoin join = (SqlJoin) from;
+ if (join.getConditionType() != JoinConditionType.USING) {
Review comment:
I will check whether there is already a test like you propose. If not, I
will add one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
