danny0405 commented on a change in pull request #1680: [CALCITE-3621] Push down
sort to DB, SQL of Sort rel contains explicit field name instead of * when sort
is not top rel
URL: https://github.com/apache/calcite/pull/1680#discussion_r361313374
##########
File path: core/src/main/java/org/apache/calcite/adapter/jdbc/JdbcRules.java
##########
@@ -765,10 +765,11 @@ public RelNode convert(RelNode rel) {
*/
public RelNode convert(Sort sort, boolean convertInputTraits) {
final RelTraitSet traitSet = sort.getTraitSet().replace(out);
+ final RelTraitSet inputTraitSet =
sort.getInput().getTraitSet().replace(out);
Review comment:
Move this line below `if (convertInputTraits)` where it is actually used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
