danny0405 commented on a change in pull request #1680: [CALCITE-3621] Push down
sort to DB, SQL of Sort rel contains explicit field name instead of * when sort
is not top rel
URL: https://github.com/apache/calcite/pull/1680#discussion_r361627381
##########
File path:
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java
##########
@@ -634,6 +634,13 @@ public Result visit(Sort e) {
}
Result x = visitChild(0, e.getInput());
Builder builder = x.builder(e, Clause.ORDER_BY);
+ if (builder.select.getSelectList() == null) {
Review comment:
Thanks @jinxing64 , after some research i agree that maybe fixing the sort
project list is the easiest way to go, but i would suggest to use `stack.size()
== 1` to decide if this sort is a root node instead of `stack.getLast().r != e`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
