xy2953396112 commented on issue #1696: [CALCITE-3634] Support Intersect and Minus on Calcs for materialized view recognition URL: https://github.com/apache/calcite/pull/1696#issuecomment-569894767 > Is this PR valid for `Minus` ? > I mean `sameRelCollectionNoOrderConsidered ` is not enough for validation checking. MinusOnCalcsToMinus should not be > Is this PR valid for `Minus` ? > I mean `sameRelCollectionNoOrderConsidered ` is not enough for validation checking. @jinxing64 Thanks for review, you are right, `MinusOnCalcsToMinusUnifyRule` should not be implemented, it may cause data errors.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
