xy2953396112 commented on a change in pull request #1696: [CALCITE-3634] Add
IntersectOnCalcsToIntersectUnifyRule for materialized view recognition
URL: https://github.com/apache/calcite/pull/1696#discussion_r392587002
##########
File path: core/src/main/java/org/apache/calcite/plan/SubstitutionVisitor.java
##########
@@ -1585,53 +1588,7 @@ private UnionOnCalcsToUnionUnifyRule() {
}
Review comment:
Thanks for review, Sorry for the late reply.
`UnionOnCalcsToUnionUnifyRule` and 'IntersectOnCalcsToIntersectUnifyRule'
have a clearer meaning. In the process of matching，If we define a rule called
`SetOpOnCalcsToSetOpUnifyRule`, We need to judge the matching logic, this
should be done by the framework itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
