danny0405 commented on a change in pull request #1709: [CALCITE-3653] Support TableModify in ToLogicalConverter URL: https://github.com/apache/calcite/pull/1709#discussion_r366708684
########## File path: core/src/test/java/org/apache/calcite/rel/logical/ToLogicalConverterTest.java ########## @@ -468,4 +468,19 @@ private void verify(RelNode rel, String expectedPhysical, String expectedLogical + " LogicalTableScan(table=[[foodmart, employee]])\n"; verify(rel(sql), expectedPhysial, expectedLogical); } + + @Test public void testTableModify() { + String sql = "insert into \"employee\" select * from \"employee\""; + RelNode rel = rel(sql); + String expectedPhysial = "" + + "JdbcToEnumerableConverter\n" + + " JdbcTableModify(table=[[foodmart, employee]], operation=[INSERT], flattened=[true])\n" + + " JdbcTableScan(table=[[foodmart, employee]])\n"; + String expectedLogical = "" + + "LogicalTableModify(table=[[foodmart, employee]], " + + "operation=[INSERT], flattened=[true])\n" + + " LogicalTableScan(table=[[foodmart, employee]])\n"; + verify(rel, expectedPhysial, expectedLogical); + } Review comment: Inline the `rel(sql)`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services