gr4ve edited a comment on issue #1766: [CALCITE-3745] UnitCompiler can not find 
required class information.
URL: https://github.com/apache/calcite/pull/1766#issuecomment-575982413
 
 
   > I also have this concern that the `Thread.getContextClassLoader` is 
unpredictable, one can set up anything to that, can we abstract a tool class 
and method(class loader member for the Compiler and a builder or something like 
that) to set up the class loader ?
   > 
   > Also, can you try to add a test case ?
   
   @danny0405 good suggestion, I have already done it. Please review the code 
and leave your comment :P

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to