gr4ve commented on issue #1766: [CALCITE-3745] UnitCompiler can not find required class information. URL: https://github.com/apache/calcite/pull/1766#issuecomment-575994447 > CalciteCompilerArgsFactory with a threadlocal is a no go. > > Can you please make the class loader to be configurable like all the other parameters? (e.g. connection property or Frameworks or whatever) We should pass it layer by layer if we use such configuration. I think it is expensive solution to resolve this problem. Every compiler instance is created by janino's CompilerFactory statically, and its default class loader is Thread.currentThread().getContextClassLoader(). Calcite overrides it to a specific class loader after creation, In most scenarios it is fine, so we can keep the original logic, and provide a mechanism for users(like me) to adapt the complicated class loading scenarios(It is a niche scenario).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
