vlsi commented on issue #1719: [CALCITE-3668] VolcanoPlanner does not match all the RelSubSet in matchRecursive URL: https://github.com/apache/calcite/pull/1719#issuecomment-578317648 @hsyuan , this looks good to me modulo `subset.getSubsets()`. I think it would be extremely confusing, especially for those who don't know how `RelSet` is different from `RelSubset`. Even though the method is not in public API, I would suggest picking a name that would convey the meaning. I don't know. `subset.getSiblingSubsetsWithMatchingTraits()`?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
