vlsi commented on issue #1740: [CALCITE-3713] Remove column names from 
Project#digest
URL: https://github.com/apache/calcite/pull/1740#issuecomment-584799605
 
 
   @xndai , I would rather add a method to `RelDataType` that computes the 
digest without taking column names to the consideration.
   
   Note: we add an opaque `Digest` interface (or even `Object`), so it does not 
tie to `String`.
   It looks like we have similar issues with `RexNode` digest, and `RelNode` 
digest. There we build strings again and again, and it might help if we would 
be able to skip building strings.
   
   I don't insist that adding `Digestable` interface is the only way to go 
here, however, I think it is a nice opportunity, and it might be helpful for 
other digests as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to