danny0405 commented on issue #1806: Following [CALCITE-3763] Fix slow test failure URL: https://github.com/apache/calcite/pull/1806#issuecomment-586544155 > From my personal view, since CALCITE-3763 prunes extra projects, we'd better modify the expected plan string as you do for CALCITE-3769. On the other hand, checking “CannotPlanException” is generally used in LatticeTest to indicate match failure, checking “AssertionError” breaks this common style and seems to be meaningless. The AssertionError expects to be introduced by CALCITE-3676, if you think it is meaningless, welcome to fire a discussion.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
