danny0405 commented on issue #1806: Following [CALCITE-3763] Fix slow test 
failure
URL: https://github.com/apache/calcite/pull/1806#issuecomment-586664017
 
 
   > It is too tiny to fire a discussion. As what you do for CALCITE-3769 
(i.e., changing the expected plan string from `LogicalTableScan` to 
`StarTableScan`), why do we not do the same thing for `testLatticeStarTable`? 
Because removing this extra `LogicalProject` is the expected result of 
CALCITE-3763.
   
   Thanks, i re-checked the plan and you are right, please also update the 
AssertError to CannotPlanException.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to