danny0405 commented on a change in pull request #1811: [CALCITE-3789] Support
validation of UNNEST multiple array columns like Presto
URL: https://github.com/apache/calcite/pull/1811#discussion_r379968866
##########
File path:
core/src/main/java/org/apache/calcite/sql/validate/DelegatingScope.java
##########
@@ -298,7 +298,11 @@ public SqlQualified fullyQualify(SqlIdentifier
identifier) {
for (; i > 0; i--) {
final SqlIdentifier prefix = identifier.getComponent(0, i);
resolved.clear();
- resolve(prefix.names, nameMatcher, false, resolved);
+ resolve(
+ prefix.names,
+ nameMatcher,
+ validator.getConformance().allowAliasUnnestArrayColumns(),
+ resolved);
Review comment:
The code may works for your case, but you have changed a common sql
identifier resolving logic with a special conformance, which seems not right
way to go ~
The conformance switch logic should always happen in SqlValidator, we can
pass along some switch flags into the scope if necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
