my7ym commented on a change in pull request #1811: [CALCITE-3789] Support
validation of UNNEST multiple array columns like Presto
URL: https://github.com/apache/calcite/pull/1811#discussion_r380288896
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlUnnestOperator.java
##########
@@ -97,6 +97,17 @@ public SqlUnnestOperator(boolean withOrdinality) {
return builder.build();
}
+ private boolean allowFlattenStruct(SqlOperatorBinding operatorBinding) {
+ if (!(operatorBinding instanceof SqlCallBinding)) {
Review comment:
> Another class type for operator binding is `RexCallBinding`, but why we
return true for that ?
This is the original behavior. Actually there are tons of SqlOperatorBinding
implementations. As the original behavior, UNNEST will ALWAYS flatten the
struct. The logic here is that we do NOT allow flatten struct ONLY for
SqlCallBinding && conformance.allowAliasUnnestArrayColumns()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
