hsyuan commented on a change in pull request #1840: [CALCITE-3753] Remove rule
queue importance
URL: https://github.com/apache/calcite/pull/1840#discussion_r388575690
##########
File path: core/src/test/java/org/apache/calcite/test/LatticeTest.java
##########
@@ -677,10 +677,10 @@ private void checkTileAlgorithm(String statisticProvider,
+ "join \"foodmart\".\"time_by_day\" using (\"time_id\")\n"
+ "group by \"the_year\"")
.enableMaterializations(true)
- .explainContains("EnumerableCalc(expr#0=[{inputs}], expr#1=[IS NOT
NULL($t0)], "
- + "expr#2=[1:BIGINT], expr#3=[0:BIGINT], expr#4=[CASE($t1, $t2,
$t3)], C=[$t4])\n"
- + " EnumerableAggregate(group=[{0}])\n"
- + " EnumerableTableScan(table=[[adhoc, m{32, 36}]])")
+ .explainContains("EnumerableCalc(expr#0..1=[{inputs}], C=[$t1])\n"
+ + " EnumerableAggregate(group=[{0}], C=[COUNT($0)])\n"
+ + " EnumerableAggregate(group=[{0}])\n"
Review comment:
I think it is orthogonal. should be done is a separate PR. The issue of cost
model exists before this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
