danny0405 commented on a change in pull request #1840: [CALCITE-3753] Remove
rule queue importance
URL: https://github.com/apache/calcite/pull/1840#discussion_r389206452
##########
File path:
core/src/main/java/org/apache/calcite/rel/rules/FilterProjectTransposeRule.java
##########
@@ -45,17 +47,13 @@
/** The default instance of
* {@link org.apache.calcite.rel.rules.FilterProjectTransposeRule}.
*
- * <p>It matches any kind of {@link org.apache.calcite.rel.core.Join} or
- * {@link org.apache.calcite.rel.core.Filter}, and generates the same kind of
- * Join and Filter.
- *
* <p>It does not allow a Filter to be pushed past the Project if
* {@link RexUtil#containsCorrelation there is a correlation condition})
* anywhere in the Filter, since in some cases it can prevent a
* {@link org.apache.calcite.rel.core.Correlate} from being de-correlated.
*/
public static final FilterProjectTransposeRule INSTANCE =
- new FilterProjectTransposeRule(Filter.class, Project.class, true, true,
+ new FilterProjectTransposeRule(LogicalFilter.class,
LogicalProject.class, true, true,
Review comment:
A breaking change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
