my7ym commented on a change in pull request #1811: [CALCITE-3789] Support
validation of UNNEST multiple array columns like Presto
URL: https://github.com/apache/calcite/pull/1811#discussion_r390620022
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -451,12 +449,9 @@ public boolean addRule(RelOptRule rule) {
assert added;
final String ruleName = rule.toString();
- if (ruleNames.put(ruleName, rule.getClass())) {
- Set<Class> x = ruleNames.get(ruleName);
- if (x.size() > 1) {
- throw new RuntimeException("Rule description '" + ruleName
- + "' is not unique; classes: " + x);
- }
+ if (ruleNames.put(ruleName, rule) != null) {
+ throw new RuntimeException("Rule description '" + ruleName
Review comment:
@danny0405 Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
