liyafan82 commented on a change in pull request #1853: [CALCITE-3851] Store
nodes with zero importance with a set
URL: https://github.com/apache/calcite/pull/1853#discussion_r391385082
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -135,16 +135,16 @@
new IdentityHashMap<>();
/**
- * The importance of relational expressions.
+ * The nodes with zero importance.
*
- * <p>The map contains only RelNodes whose importance has been overridden
+ * <p>The set contains only RelNodes whose importance has been set to 0
* using {@link RelOptPlanner#setImportance(RelNode, double)}. Other
* RelNodes are presumed to have 'normal' importance.
*
* <p>If a RelNode has 0 importance, all {@link RelOptRuleCall}s using it
* are ignored, and future RelOptRuleCalls are not queued up.
*/
- final Map<RelNode, Double> relImportances = new HashMap<>();
+ final Set<RelNode> nodesToSkip = new HashSet<>();
Review comment:
Sounds good. Revised accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
