hsyuan commented on a change in pull request #1853: [CALCITE-3851] Replace the 
node importance map with a set for pruned nodes
URL: https://github.com/apache/calcite/pull/1853#discussion_r392455605
 
 

 ##########
 File path: 
core/src/main/java/org/apache/calcite/plan/AbstractRelOptPlanner.java
 ##########
 @@ -221,9 +221,13 @@ public long getRelMetadataTimestamp(RelNode rel) {
     return 0;
   }
 
+  @Deprecated
   public void setImportance(RelNode rel, double importance) {
   }
 
+  public void pruneNode(RelNode rel) {
+  }
 
 Review comment:
   Is it possible to add a API to `RelNode`? e.g.
   ```
   void RelNode.setPruned();
   boolean RelNode.isPruned();
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to