kgyrtkirk commented on a change in pull request #1868: [CALCITE-3867] Support
RelDistribution json serialization
URL: https://github.com/apache/calcite/pull/1868#discussion_r397084324
##########
File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java
##########
@@ -190,8 +193,35 @@ public RelFieldCollation toFieldCollation(Map<String,
Object> map) {
return new RelFieldCollation(field, direction, nullDirection);
}
- public RelDistribution toDistribution(Object o) {
- return RelDistributions.ANY; // TODO:
+ public RelDistribution toDistribution(Map<String, Object> map) {
+ final RelDistribution.Type type =
Review comment:
@chunweilei I don't think this is a breaking change - this `RelJson` class
is only used from `RelJsonReader` - and it doesn't seem valueable outside of
that (note: I think `RelJson` could be viewed as an implementation detail and
as such it could be made package private)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
