chunweilei commented on a change in pull request #1868: [CALCITE-3867] Support
RelDistribution json serialization
URL: https://github.com/apache/calcite/pull/1868#discussion_r399006271
##########
File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java
##########
@@ -190,8 +193,35 @@ public RelFieldCollation toFieldCollation(Map<String,
Object> map) {
return new RelFieldCollation(field, direction, nullDirection);
}
- public RelDistribution toDistribution(Object o) {
- return RelDistributions.ANY; // TODO:
+ public RelDistribution toDistribution(Map<String, Object> map) {
+ final RelDistribution.Type type =
Review comment:
Every public method is a public API. But I don't have a strong objection
about it since it is not a frequently used api.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
