danny0405 commented on a change in pull request #1837: [CALCITE-3835]
Overloaded table functions fail with an assertion error if param types differ
URL: https://github.com/apache/calcite/pull/1837#discussion_r398548086
##########
File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java
##########
@@ -568,36 +572,44 @@ private void addTableMacro(Connection connection, Method
method) throws SQLExcep
checkTableFunctionInModel(Smalls.TestStaticTableFunction.class);
}
- private CalciteAssert.AssertThat assertWithMacro(Class clazz) {
+ private CalciteAssert.AssertThat assertOverloadedWithMacro(Class<?>...
clazz) {
+ String prefix = ""
Review comment:
I think we should keep the old name. The passed in param is not necessary to
be an array, so it maybe not overloaded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
