vvysotskyi commented on a change in pull request #1837: [CALCITE-3835] Overloaded table functions fail with an assertion error if param types differ URL: https://github.com/apache/calcite/pull/1837#discussion_r398808399
########## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ########## @@ -568,36 +572,44 @@ private void addTableMacro(Connection connection, Method method) throws SQLExcep checkTableFunctionInModel(Smalls.TestStaticTableFunction.class); } - private CalciteAssert.AssertThat assertWithMacro(Class clazz) { + private CalciteAssert.AssertThat assertOverloadedWithMacro(Class<?>... clazz) { + String prefix = "" Review comment: Ok, thanks for pointing this, reverted changing method name. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services