danny0405 commented on a change in pull request #1811: [CALCITE-3789] Support
validation of UNNEST multiple array columns like Presto
URL: https://github.com/apache/calcite/pull/1811#discussion_r403423858
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java
##########
@@ -2047,8 +2047,15 @@ protected void convertFrom(
case AS:
call = (SqlCall) from;
- convertFrom(bb, call.operand(0));
- if (call.operandCount() > 2
+ SqlNode firstOperand = call.operand(0);
+
+ if (firstOperand.getKind() == SqlKind.UNNEST) {
+ convertUnnest(bb, (SqlCall) firstOperand, getFieldAliases(call));
+ } else {
+ convertFrom(bb, firstOperand);
+ }
Review comment:
The operator row type belongs to the Validator namespace, i think we should
fix it there instead of `SqlToRelConverter`. Maybe you should try
`AliasNamespace`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
