julianhyde commented on a change in pull request #1811: [CALCITE-3789] Support
validation of UNNEST multiple array columns like Presto
URL: https://github.com/apache/calcite/pull/1811#discussion_r404215075
##########
File path: core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java
##########
@@ -2219,6 +2207,42 @@ protected void convertFrom(
}
}
+ private List<String> getFieldAliases(SqlCall asCall) {
Review comment:
This method needs javadoc
Is returning null the best thing? If it's illegal to call the method, you
should throw. I hate nullable returns.
Conformance usually applies during validation, not during sql-to-rel. You
know validation has succeeded at this point. If only one thing is possible, you
should just do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
