hsyuan commented on a change in pull request #1860: [CALCITE-2970] Add
abstractConverter only between derived and required traitset
URL: https://github.com/apache/calcite/pull/1860#discussion_r405928980
##########
File path: core/src/main/java/org/apache/calcite/rel/core/Sort.java
##########
@@ -157,6 +157,11 @@ public RelNode accept(RexShuttle shuttle) {
return copy(traitSet, getInput(), collation, offset, fetch);
}
+ @Override public boolean isEnforcer() {
+ return offset == null && fetch == null
Review comment:
I know it is confusing, but it is the design (Sort operator mixes both sort
and limit operator) that leads to the confusion. We should have a separate
LIMIT operator, SORT operator should not have limit and offset.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
