amaliujia commented on a change in pull request #1761:
URL: https://github.com/apache/calcite/pull/1761#discussion_r411090220
##########
File path:
core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java
##########
@@ -2296,8 +2298,14 @@ public void unparse(
/** DESCRIPTOR(column_name, ...). */
public static final SqlOperator DESCRIPTOR = new SqlDescriptorOperator();
- /** TUMBLE as a table-value function. */
- public static final SqlFunction TUMBLE_TVF = new
SqlWindowTableFunction(SqlKind.TUMBLE.name());
+ /** TUMBLE as a table function. */
+ public static final SqlFunction TUMBLE_TVF = new SqlTumbleTableFunction();
+
+ /** HOP as a table function. */
+ public static final SqlFunction HOP_TVF = new SqlHopTableFunction();
+
+ /** SESSION as a table function. */
+ public static final SqlFunction SESSION_TVF = new SqlSessionTableFunction();
Review comment:
TVF is the abbrev for "table-valued function". To clarify,
"table-valued function" is the term used in SQL standard. But seems like people
in Calcite community like the short version: table function.
I can rename it, but it will be better to use, e.g. HOP_TABLE_FUNCTION. What
do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
