amaliujia commented on a change in pull request #1761:
URL: https://github.com/apache/calcite/pull/1761#discussion_r411102483



##########
File path: core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java
##########
@@ -1778,15 +1778,16 @@ public final Sql sql(String sql) {
 
   // In generated plan, the first parameter of TUMBLE function will always be 
the last field
   // of it's input. There isn't a way to give the first operand a proper type.
-  @Test void testTableValuedFunctionTumble() {
+
+  @Test public void testTableFunctionTumble() {
     final String sql = "select *\n"
         + "from table(tumble(table Shipments, descriptor(rowtime), INTERVAL 
'1' MINUTE))";
     sql(sql).ok();
   }
 
   // In generated plan, the first parameter of TUMBLE function will always be 
the last field
   // of it's input. There isn't a way to give the first operand a proper type.
-  @Test void testTableValuedFunctionTumbleWithSubQueryParam() {
+  @Test public void testTableFunctionTumbleWithSubQueryParam() {
     final String sql = "select *\n"
         + "from table(tumble((select * from Shipments), descriptor(rowtime), 
INTERVAL '1' MINUTE))";

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to