xndai commented on a change in pull request #1884:
URL: https://github.com/apache/calcite/pull/1884#discussion_r416318880
##########
File path: core/src/main/java/org/apache/calcite/rel/RelCollationTraitDef.java
##########
@@ -61,18 +65,21 @@ public RelCollation getDefault() {
public RelNode convert(
RelOptPlanner planner,
+ RelBuilder builder,
RelNode rel,
RelCollation toCollation,
+ Convention toConvention,
Review comment:
We could move the convert logic to Convention class as you suggested.
But I think that can be done in a separate change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
