xndai commented on a change in pull request #1884:
URL: https://github.com/apache/calcite/pull/1884#discussion_r418133536
##########
File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java
##########
@@ -230,6 +230,18 @@ public RelDataTypeFactory getTypeFactory() {
return cluster.getTypeFactory();
}
+ /** Return the RelFactories Struct. */
+ public RelFactories.Struct getRelFactoriesStruct() {
+ return this.struct;
+ }
+
+ /** Set the RelFactories Struct. Conventions can use a different
RelFactories struct to
+ * create physical RelNode.*/
+ public RelBuilder setRelFactoriesStruct(RelFactories.Struct newStruct) {
+ this.struct = newStruct;
+ return this;
+ }
+
Review comment:
Can you take a look at the JIRA discussion? If we cannot address the two
points I raised, we couldn't use the way you suggest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
