chunweilei commented on a change in pull request #1991:
URL: https://github.com/apache/calcite/pull/1991#discussion_r450077922
##########
File path: core/src/test/resources/sql/agg.iq
##########
@@ -2290,9 +2290,9 @@ select MGR, count(distinct DEPTNO, JOB), MIN(SAL),
MAX(SAL) from "scott".emp gro
!ok
-EnumerableAggregate(group=[{0}], EXPR$1=[COUNT($1, $2) FILTER $5],
EXPR$2=[MIN($3) FILTER $6], EXPR$3=[MIN($4) FILTER $6])
- EnumerableCalc(expr#0..5=[{inputs}], expr#6=[0], expr#7=[=($t5, $t6)],
expr#8=[3], expr#9=[=($t5, $t8)], MGR=[$t1], DEPTNO=[$t2], JOB=[$t0],
EXPR$2=[$t3], EXPR$3=[$t4], $g_0=[$t7], $g_3=[$t9])
- EnumerableAggregate(group=[{2, 3, 7}], groups=[[{2, 3, 7}, {3}]],
EXPR$2=[MIN($5)], EXPR$3=[MAX($5)], $g=[GROUPING($3, $7, $2)])
+EnumerableAggregate(group=[{1}], EXPR$1=[COUNT($2, $0) FILTER $5],
EXPR$2=[MIN($3) FILTER $6], EXPR$3=[MIN($4) FILTER $6])
+ EnumerableCalc(expr#0..5=[{inputs}], expr#6=[0], expr#7=[=($t5, $t6)],
expr#8=[5], expr#9=[=($t5, $t8)], proj#0..4=[{exprs}], $g_0=[$t7], $g_5=[$t9])
+ EnumerableAggregate(group=[{2, 3, 7}], groups=[[{2, 3, 7}, {3}]],
EXPR$2=[MIN($5)], EXPR$3=[MAX($5)], $g=[GROUPING($2, $3, $7)])
EnumerableTableScan(table=[[scott, EMP]])
Review comment:
Is the change expected?
##########
File path:
cassandra/src/test/java/org/apache/calcite/test/CassandraAdapterTest.java
##########
@@ -100,8 +100,8 @@ static void load(Session session) {
.returns("tweet_id=f3c329de-d05b-11e5-b58b-90e2ba530b12\n"
+ "tweet_id=f3dbb03a-d05b-11e5-b58b-90e2ba530b12\n")
.explainContains("PLAN=CassandraToEnumerableConverter\n"
- + " CassandraLimit(fetch=[2])\n"
- + " CassandraProject(tweet_id=[$2])\n"
+ + " CassandraProject(tweet_id=[$2])\n"
+ + " CassandraLimit(fetch=[2])\n"
+ " CassandraFilter(condition=[=($0, '!PUBLIC!')])\n");
}
Review comment:
Does the same cost lead to the change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
