DonnyZone commented on a change in pull request #2060:
URL: https://github.com/apache/calcite/pull/2060#discussion_r452614612
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java
##########
@@ -856,11 +856,6 @@ public boolean isNullable(RexNode e) {
return e.getType().isNullable();
}
- public RexToLixTranslator setNullable(
- Map<? extends RexNode, Boolean> nullable) {
- return this;
- }
Review comment:
Yes, it is useless in current algorithm.
Before CALCITE-3224, we need to maintain RexNode's nullable state in
`RexToLixTranslator`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
