DonnyZone commented on a change in pull request #2060:
URL: https://github.com/apache/calcite/pull/2060#discussion_r452753787
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/StrictAggImplementor.java
##########
@@ -148,13 +146,7 @@ public final void implementAdd(AggContext info, final
AggAddContext add) {
return;
}
- final Map<RexNode, Boolean> nullables = new HashMap<>();
- for (RexNode arg : args) {
- if (translator.isNullable(arg)) {
- nullables.put(arg, false);
- }
Review comment:
Because the initial algorithm assumes the null checking logic for `args`
has already been conducted, and it wants to tell the `translator` that "you can
treat these RexNode as nullable=false".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
