rubenada commented on a change in pull request #2071:
URL: https://github.com/apache/calcite/pull/2071#discussion_r456297775
##########
File path: core/src/main/java/org/apache/calcite/rel/AbstractRelNode.java
##########
@@ -177,7 +177,8 @@ public void register(RelOptPlanner planner) {
Util.discard(planner);
}
- public final String getRelTypeName() {
+ // It is not recommended to override this method, but sub-classes can do it
at their own risk.
+ public String getRelTypeName() {
Review comment:
I think there is a very complete description in the [javadoc of the
interface
RelNode](https://github.com/apache/calcite/blob/a4fa05458840cfdd93fb5cba16d102b06197539d/core/src/main/java/org/apache/calcite/rel/RelNode.java#L367);
we could copy-paste it in here, but I think it would be redundant and less
simple to maintain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
