rubenada commented on a change in pull request #2071:
URL: https://github.com/apache/calcite/pull/2071#discussion_r456315360
##########
File path: core/src/main/java/org/apache/calcite/rel/AbstractRelNode.java
##########
@@ -177,7 +177,8 @@ public void register(RelOptPlanner planner) {
Util.discard(planner);
}
- public final String getRelTypeName() {
+ // It is not recommended to override this method, but sub-classes can do it
at their own risk.
+ public String getRelTypeName() {
Review comment:
The original javadoc is the one from the interface (RelNode), which is a
contract, so I think its documentation is still valid. Overridden
implementations must respect this contract, but they can implement it in a
different way, e.g. returning a String literal with the class name, instead of
using the default mechanism of AbstractRelNode based on getClass().getName()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
