rubenada commented on a change in pull request #2080:
URL: https://github.com/apache/calcite/pull/2080#discussion_r460165174
##########
File path:
linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java
##########
@@ -2636,6 +2636,56 @@ public static boolean isMergeJoinSupported(JoinType
joinType) {
return orderBy(source, keySelector, Collections.reverseOrder(comparator));
}
+ /**
+ * A sort implementation based on a heap (or priority queue).
Review comment:
I think this javadoc should mention that this sort implementation
handles also fetch & offset, and what they mean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
