rubenada commented on a change in pull request #2080:
URL: https://github.com/apache/calcite/pull/2080#discussion_r460171954
##########
File path:
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableLimitRule.java
##########
@@ -48,6 +48,9 @@
sort.getCollation(),
null,
null);
+ if (input == null) {
Review comment:
I understand that now this rule presents a problem if it matches an
EnumerableTopNHeapSort, and we should not split it into EnumerableLimit +
sortCopy because EnumerableTopNHeapSort is already implementing the Limit
logic. So maybe we could add to the rule that `if (sort instanceof
EnumerableTopNHeapSort) return;`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
