amaliujia commented on a change in pull request #2092:
URL: https://github.com/apache/calcite/pull/2092#discussion_r464767103
##########
File path: core/src/main/codegen/templates/Parser.jj
##########
@@ -1822,23 +1822,47 @@ List<SqlNode> SelectList() :
SqlNode SelectItem() :
{
SqlNode e;
+ SqlIdentifier columnAlias;
+ final List<SqlNode> columnAliases = new ArrayList();
+ final Span s = span();
final SqlIdentifier id;
Review comment:
@danny0405 I was always confusion on how to correct use `span()`. Is
there some documentation you know that explains how `span()` (and position)
work?
##########
File path: core/src/main/codegen/templates/Parser.jj
##########
@@ -1822,23 +1822,47 @@ List<SqlNode> SelectList() :
SqlNode SelectItem() :
{
SqlNode e;
+ SqlIdentifier columnAlias;
+ final List<SqlNode> columnAliases = new ArrayList();
+ final Span s = span();
final SqlIdentifier id;
Review comment:
@danny0405 I was always confused on how to correct use `span()`. Is
there some documentation you know that explains how `span()` (and position)
work?
##########
File path: core/src/main/codegen/templates/Parser.jj
##########
@@ -1822,23 +1822,47 @@ List<SqlNode> SelectList() :
SqlNode SelectItem() :
{
SqlNode e;
+ SqlIdentifier columnAlias;
+ final List<SqlNode> columnAliases = new ArrayList();
+ final Span s = span();
final SqlIdentifier id;
Review comment:
@danny0405 I was always confused on how to correctly use `span()`. Is
there some documentation you know that explains how `span()` (and position)
work?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
