danny0405 commented on a change in pull request #2092:
URL: https://github.com/apache/calcite/pull/2092#discussion_r464771796
##########
File path: core/src/main/codegen/templates/Parser.jj
##########
@@ -1822,23 +1822,47 @@ List<SqlNode> SelectList() :
SqlNode SelectItem() :
{
SqlNode e;
+ SqlIdentifier columnAlias;
+ final List<SqlNode> columnAliases = new ArrayList();
+ final Span s = span();
final SqlIdentifier id;
Review comment:
The implementation code for `span()` is `Span.of(getPos())`, which
contains the position of the last visited token. For example, if i have a parse
block:
```java
<AS> ... span()
```
The span would contains the position of the `<AS>` token.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
