danny0405 commented on a change in pull request #2093:
URL: https://github.com/apache/calcite/pull/2093#discussion_r464938856
##########
File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java
##########
@@ -993,7 +993,7 @@ public static SqlDataTypeSpec convertTypeToSpec(RelDataType
type,
assert typeName != null;
final SqlTypeNameSpec typeNameSpec;
- if (isAtomic(type)) {
+ if (isAtomic(type) || isNull(type)) {
Review comment:
This change seems not necessary any more ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
