anha1 commented on a change in pull request #2093:
URL: https://github.com/apache/calcite/pull/2093#discussion_r464950680
##########
File path: core/src/main/java/org/apache/calcite/sql/type/SqlTypeUtil.java
##########
@@ -993,7 +993,7 @@ public static SqlDataTypeSpec convertTypeToSpec(RelDataType
type,
assert typeName != null;
final SqlTypeNameSpec typeNameSpec;
- if (isAtomic(type)) {
+ if (isAtomic(type) || isNull(type)) {
Review comment:
I would like to keep it as far as it fixes an issue in a public utility
method. But thank you for spotting that SQL tests no longer hit it, so I
covered this fix in SqlTypeUtilTest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
