chunweilei commented on a change in pull request #2094:
URL: https://github.com/apache/calcite/pull/2094#discussion_r468971222
##########
File path:
core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java
##########
@@ -279,6 +282,10 @@ public RelNode getRoot() {
return ImmutableList.copyOf(materializations);
}
+ @Override public void registerMaterializationRules(List<UnifyRule> rules) {
+ materializationRules = ImmutableList.copyOf(rules);
+ }
+
Review comment:
This interface is a little confusing. Because even user does not call
this method, normal rules are still be added. Maybe
`addExtraMaterializationRules`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
