xy2953396112 commented on a change in pull request #2094:
URL: https://github.com/apache/calcite/pull/2094#discussion_r479627601
##########
File path:
core/src/main/java/org/apache/calcite/plan/RelOptMaterializations.java
##########
@@ -60,7 +60,8 @@
* materialized views used in the transformation.
*/
public static List<Pair<RelNode, List<RelOptMaterialization>>>
useMaterializedViews(
- final RelNode rel, List<RelOptMaterialization> materializations) {
+ final RelNode rel, List<RelOptMaterialization> materializations,
+ List<SubstitutionVisitor.UnifyRule> materializationRules) {
final List<RelOptMaterialization> applicableMaterializations =
getApplicableMaterializations(rel, materializations);
Review comment:
Should we keep the default implementation without custom materialized
recognition rules? Method overloading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
