amaliujia commented on a change in pull request #2103:
URL: https://github.com/apache/calcite/pull/2103#discussion_r469610312
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlWindowTableFunction.java
##########
@@ -98,8 +173,8 @@ private static RelDataType inferRowType(SqlOperatorBinding
opBinding) {
return typeFactory.builder()
.kind(inputRowType.getStructKind())
.addAll(inputRowType.getFieldList())
- .add("window_start", timestampType)
- .add("window_end", timestampType)
+ .add("wstart", timestampType)
+ .add("wend", timestampType)
Review comment:
Note that I asked one of the authors of the "one sql to rule them all"
paper. The only reason that they use wstart and wend was because of the layout
for a paper.
I also believe in a JIRA or an email (sorry I cannot recall which one it is)
we agreed to switch to window_start and window_end.
So I will suggest we keep window_start and window_end, which can be
understood easier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
