amaliujia commented on a change in pull request #2103:
URL: https://github.com/apache/calcite/pull/2103#discussion_r469747848
##########
File path: core/src/main/java/org/apache/calcite/sql/SqlWindowTableFunction.java
##########
@@ -98,8 +173,8 @@ private static RelDataType inferRowType(SqlOperatorBinding
opBinding) {
return typeFactory.builder()
.kind(inputRowType.getStructKind())
.addAll(inputRowType.getFieldList())
- .add("window_start", timestampType)
- .add("window_end", timestampType)
+ .add("wstart", timestampType)
+ .add("wend", timestampType)
Review comment:
ok. I might or might not discussed this in Calcite (because I cannot
find a JIRA that about it), but
1. This is the acknowledge from Kenneth Knowles, one of the paper authors:
https://docs.google.com/document/d/138uA7VTpbF84CFrd--cz3YVe0-AQ9ALnsavaSE2JeE4/edit?disco=AAAAEAjWvxg
2. I started to use window_start and window_end in
https://issues.apache.org/jira/browse/CALCITE-3272. Julian, as another paper
author, didn't against it I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
