amaliujia commented on a change in pull request #2105:
URL: https://github.com/apache/calcite/pull/2105#discussion_r469611797
##########
File path:
core/src/test/resources/org/apache/calcite/test/SqlToRelConverterTest.xml
##########
@@ -3763,7 +3765,7 @@ LogicalProject(DEPTNO=[$7])
</TestCase>
<TestCase name="testReduceConstExpr">
<Resource name="sql">
- <![CDATA[select sum(case when 'y' = 'n' then ename else 1 end)
from emp]]>
+ <![CDATA[select sum(case when 'y' = 'n' then ename else 0.1 end)
from emp]]>
</Resource>
Review comment:
+1. The test case should be using `1`:
https://github.com/apache/calcite/blob/37b8cdbb381369e773229a81ae69ab5c1df34f3e/core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java#L2649
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
