julianhyde commented on a change in pull request #2105:
URL: https://github.com/apache/calcite/pull/2105#discussion_r469741260
##########
File path: core/src/test/java/org/apache/calcite/rex/RexProgramBuilderBase.java
##########
@@ -306,6 +306,14 @@ protected RexNode gt(RexNode n1, RexNode n2) {
return rexBuilder.makeCall(SqlStdOperatorTable.GREATER_THAN, n1, n2);
}
+ protected RexNode like(RexNode ref, RexNode pattern) {
+ return rexBuilder.makeCall(SqlStdOperatorTable.LIKE, ref, pattern);
+ }
+
+ protected RexNode like(RexNode ref, RexNode pattern, RexNode escape) {
+ return rexBuilder.makeCall(SqlStdOperatorTable.LIKE, ref, pattern, escape);
+ }
+
Review comment:
I disagree. There are lots of surrounding methods with a similar
pattern. They are protected methods in a test case. Javadoc would not add
anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
