whuGuo commented on a change in pull request #1664:
URL: https://github.com/apache/calcite/pull/1664#discussion_r472948316
##########
File path: core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java
##########
@@ -11236,6 +11236,35 @@ private void checkCustomColumnResolving(String table) {
assertThat(resultType.toString(), is("INTEGER"));
}
+ @Test public void testGroupByAlias() {
+ // test group by alias, when the underlying column in the expression is
the same as the alias
+ sql("select DEPTNO+1 as DEPTNO from emp group by DEPTNO+1")
+ .withConformance(SqlConformanceEnum.LENIENT)
+ .ok();
Review comment:
In LENIENT, Calcite's behavior should be very much like PostgreSQL.
PostgreSQL is group by underlying column.
so let isGroupByAlias in LENIENT conformance is false can make it right.
thank your review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]